Adding STORM32_V1_31_RC variant #1375

owennewo · 2021-04-28T20:19:27Z

Summary

Adding STORM32_V1_31_RC variantI

I've placed this in the ESC_board menu - technically it is a 3axis gimbal controller (not an ESC) but it can be used as an ESC for smaller motors.

This is a very popular board designed by Olliw (I have no affiliation).
http://www.olliw.eu/storm32bgc-wiki/Main_Page

Validation
I've tested this using SimpleFOC library and have most things working

SerialUSB, Serial3, I2C1, I2C2
Can spin 3 motors

Here is an example sketch of it in use:
https://gist.github.com/owennewo/68c3de58d3e14b702552f0c149de41b0

fpistm

Hi @owennewo
Thanks for your contribution.
Nice first PR moreover you are the first contributor with the new format.
Hope it was not so hard, wiki will be updated soon.

In addition to my comments could you also update the README.md to reference it in the ESC section.
Moreover it is not very clear for me which board STorM32 board you add?
Is it this one ? http://www.olliw.eu/storm32bgc-wiki/STorM32_Boards#STorM32-BGC_v1.3
In that case why RC instead of BGC ?

Tthank you in advance.

boards.txt

variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.cpp

variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_RC.c

owennewo · 2021-04-30T15:15:48Z

I've repushed with a README.

Yes that link is correct. RC refers to STM32F103RC which is by far the most common flash size version (and is the one I have), but as this board is open source, people have made RB, RE and RG versions which I've not tested and don't really know whether they'll work. If you'd prefer me to remove the RC from the name, so that others can later add support for different flash sizes then I can do that. I can also add BGC (which I think stands for Brushless Gimbal Controller) if you like.

fpistm · 2021-04-30T16:54:05Z

Thanks for the README.
About the different flash size, in fact it can be managed easily by adding correct boards entry in the boards.txt and renaming the variant_STORM32_V1_31_RC.* and peripheralPins_STORM32_V1_31_RC.c to
variant_STORM32_V1_31_Rx.* and peripheralPins_STORM32_V1_31_Rx.c

Then adding in the boards.txt:

# STORM32_V1_RC board
ESC_board.menu.pnum.STORM32_V1_31_RC=STorM32 BGC v1.31 RC
ESC_board.menu.pnum.STORM32_V1_31_RC.upload.maximum_size=262144
ESC_board.menu.pnum.STORM32_V1_31_RC.upload.maximum_data_size=49152
ESC_board.menu.pnum.STORM32_V1_31_RC.build.mcu=cortex-m3
ESC_board.menu.pnum.STORM32_V1_31_RC.build.board=STORM32_V1_31_RC
ESC_board.menu.pnum.STORM32_V1_31_RC.build.series=STM32F1xx
ESC_board.menu.pnum.STORM32_V1_31_RC.build.product_line=STM32F103xE
ESC_board.menu.pnum.STORM32_V1_31_RC.build.peripheral_pins=-DCUSTOM_PERIPHERAL_PINS
ESC_board.menu.pnum.STORM32_V1_31_RC.build.cmsis_lib_gcc=arm_cortexM3l_math
ESC_board.menu.pnum.STORM32_V1_31_RC.build.variant=STM32F1xx/F103R(C-D-E)T
ESC_board.menu.pnum.STORM32_V1_31_RC.build.variant_h=variant_STORM32_V1_31_Rx.h

# STORM32_V1_RD board
ESC_board.menu.pnum.STORM32_V1_31_RD=STorM32 BGC v1.31 RD
ESC_board.menu.pnum.STORM32_V1_31_RD.upload.maximum_size=393216
ESC_board.menu.pnum.STORM32_V1_31_RD.upload.maximum_data_size=65536
ESC_board.menu.pnum.STORM32_V1_31_RD.build.mcu=cortex-m3
ESC_board.menu.pnum.STORM32_V1_31_RD.build.board=STORM32_V1_31_RD
ESC_board.menu.pnum.STORM32_V1_31_RD.build.series=STM32F1xx
ESC_board.menu.pnum.STORM32_V1_31_RD.build.product_line=STM32F103xE
ESC_board.menu.pnum.STORM32_V1_31_RD.build.peripheral_pins=-DCUSTOM_PERIPHERAL_PINS
ESC_board.menu.pnum.STORM32_V1_31_RD.build.cmsis_lib_gcc=arm_cortexM3l_math
ESC_board.menu.pnum.STORM32_V1_31_RD.build.variant=STM32F1xx/F103R(C-D-E)T
ESC_board.menu.pnum.STORM32_V1_31_RD.build.variant_h=variant_STORM32_V1_31_Rx.h

# STORM32_V1_RE board
ESC_board.menu.pnum.STORM32_V1_31_RE=STorM32 BGC v1.31 RE
ESC_board.menu.pnum.STORM32_V1_31_RE.upload.maximum_size=524288
ESC_board.menu.pnum.STORM32_V1_31_RE.upload.maximum_data_size=65536
ESC_board.menu.pnum.STORM32_V1_31_RE.build.mcu=cortex-m3
ESC_board.menu.pnum.STORM32_V1_31_RE.build.board=STORM32_V1_31_RE
ESC_board.menu.pnum.STORM32_V1_31_RE.build.series=STM32F1xx
ESC_board.menu.pnum.STORM32_V1_31_RE.build.product_line=STM32F103xE
ESC_board.menu.pnum.STORM32_V1_31_RE.build.peripheral_pins=-DCUSTOM_PERIPHERAL_PINS
ESC_board.menu.pnum.STORM32_V1_31_RE.build.cmsis_lib_gcc=arm_cortexM3l_math
ESC_board.menu.pnum.STORM32_V1_31_RE.build.variant=STM32F1xx/F103R(C-D-E)T
ESC_board.menu.pnum.STORM32_V1_31_RE.build.variant_h=variant_STORM32_V1_31_Rx.h

And in each files adding the correct switch:
#if defined(ARDUINO_STORM32_V1_31_RC) || defined(ARDUINO_STORM32_V1_31_RD) || defined(ARDUINO_STORM32_V1_31_RE)

In fact the linker script is preprocessed so the correct flash and RAM size will be used:

Arduino_Core_STM32/variants/STM32F1xx/F103R(C-D-E)T/ldscript.ld

Lines 36 to 41 in 0a3fa54

    
           /* Memories definition */ 
        
           MEMORY 
        
           { 
        
             RAM    (xrw)    : ORIGIN = 0x20000000,   LENGTH = LD_MAX_DATA_SIZE 
        
             FLASH    (rx)    : ORIGIN = 0x8000000 + LD_FLASH_OFFSET, LENGTH = LD_MAX_SIZE - LD_FLASH_OFFSET 
        
           }

Note that you didn't fix my other review comments.

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Co-authored-by: Frederic Pillon <[email protected]>

owennewo · 2021-04-30T18:13:54Z

I'll retest after accepting your changes. The Serial3/SerialUSB took me a while to get working automatically so this is the area I'm not confident in - perhaps something else is missing in this area.

Regaring RC/RB/RE/RG versions of this board - I think I confused myself and you

RC - exists
RE - only exists in a later variant (3.x which is quite different)
RB and RG are mentioned in this schematic https://community.simplefoc.com/uploads/default/original/1X/6f1cdb4a8d6bfdd6d405aa340ca2571f5be42738.jpeg but I've not seen them for sale. I don't think they exist!
TLDR: I think we only need single flash size RC

…RC.c

README.md

fpistm · 2021-05-03T08:15:03Z

OK so we can kept only one variant.

The Serial3/SerialUSB took me a while to get working automatically so this is the area I'm not confident in - perhaps something else is missing in this area.

I'm confident 😉

fpistm

PR LGTM. Only one question about the HAL_SD_MODULE_ENABLED .

variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

This will allow #define Serial SerialUSB

Co-authored-by: Frederic Pillon <[email protected]>

owennewo · 2021-05-03T11:44:17Z

OK so we can kept only one variant.

The Serial3/SerialUSB took me a while to get working automatically so this is the area I'm not confident in - perhaps something else is missing in this area.

I'm confident

I found the issue - ESC_board.menu was missing CDC (generic 'Serial' supersede U(S)ART) (I was using CDC (No generic Serial) )

Hopefully this is ready to merge

boards.txt

fpistm · 2021-05-03T12:45:11Z

I found the issue - ESC_board.menu was missing CDC (generic 'Serial' supersede U(S)ART) (I was using CDC (No generic Serial) )

Nice catch I missed that. 🙄

Hopefully this is ready to merge

Yes, I've made a small update of USB menu entry.

owennewo added 3 commits April 28, 2021 20:50

Adding STORM32_V1_31_RC variant

6266208

fixing AStyle for STORM32 variant

8f806a2

removing commented out code

84e5ed7

fpistm added the new variant Add support of new bard label Apr 29, 2021

fpistm added this to the 2.x.x milestone Apr 29, 2021

fpistm requested changes Apr 29, 2021

View reviewed changes

adding to README for STorM32

d88203f

owennewo and others added 9 commits April 30, 2021 19:07

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

221cca3

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

8039dd5

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

c297866

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

aaf589d

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

a89c32f

…RC.c Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

e69d005

Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

1b0af3e

Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

95987c8

Co-authored-by: Frederic Pillon <[email protected]>

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.cpp

a84f585

Co-authored-by: Frederic Pillon <[email protected]>

fpistm added 3 commits May 3, 2021 10:08

Update boards.txt

b25f8b4

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.cpp

529b452

Update variants/STM32F1xx/F103R(C-D-E)T/PeripheralPins_STORM32_V1_31_…

ca3b884

…RC.c

fpistm reviewed May 3, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

e330d2e

fpistm reviewed May 3, 2021

View reviewed changes

variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h Outdated Show resolved Hide resolved

owennewo and others added 2 commits May 3, 2021 12:41

Adding 'CDC (generic 'Serial' supersede U(S)ART)'

1963c8e

This will allow #define Serial SerialUSB

Update variants/STM32F1xx/F103R(C-D-E)T/variant_STORM32_V1_31_RC.h

bdd398d

Co-authored-by: Frederic Pillon <[email protected]>

fpistm reviewed May 3, 2021

View reviewed changes

boards.txt Outdated Show resolved Hide resolved

Update boards.txt

b13abe1

fpistm approved these changes May 3, 2021

View reviewed changes

fpistm merged commit 66b01b0 into stm32duino:master May 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding STORM32_V1_31_RC variant #1375

Adding STORM32_V1_31_RC variant #1375

owennewo commented Apr 28, 2021

fpistm left a comment

owennewo commented Apr 30, 2021

fpistm commented Apr 30, 2021 •

edited

Loading

owennewo commented Apr 30, 2021

fpistm commented May 3, 2021

fpistm left a comment

owennewo commented May 3, 2021

fpistm commented May 3, 2021

Adding STORM32_V1_31_RC variant #1375

Adding STORM32_V1_31_RC variant #1375

Conversation

owennewo commented Apr 28, 2021

fpistm left a comment

Choose a reason for hiding this comment

owennewo commented Apr 30, 2021

fpistm commented Apr 30, 2021 • edited Loading

owennewo commented Apr 30, 2021

fpistm commented May 3, 2021

fpistm left a comment

Choose a reason for hiding this comment

owennewo commented May 3, 2021

fpistm commented May 3, 2021

fpistm commented Apr 30, 2021 •

edited

Loading